Show most recent feedback first#91
Merged
Merged
Conversation
- Move 'View Panelists' from help area to a proper tab in tabbed_templates_html - Add subject field to view_panelists template for tab label - Wrap each interview's feedback in a Bootstrap 5 collapse (expanded by default) so reviewers can collapse per-interview sections - Sort open answer feedback in reverse chronological order (newest first) - Convert markdown inside collapse divs to HTML (blockquote, hr, links) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Convert markdown table to HTML in reviews_table_template — markdown tables don't render after a block-level HTML element (collapse_template) - Add ORDER BY datetime DESC to get_all_feedback_info query so reviews are sorted newest-first at the database level - Since SQL now returns rows newest-first, inserting into the dict naturally orders interviews by their most recent review (first encounter per interview = most recent entry for that interview) - Remove Python-side sort from text_reviews code block Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Uses ALToolbox's existing pdcaretopen/pdcaretclosed CSS pattern with fa_icon caret-down (expanded) and caret-right (collapsed). Bootstrap toggles the 'collapsed' class on the anchor automatically. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace ${ review['body'] } with ${ markdown_to_html(review['body']) }.
markdown_to_html() converts the body text (which may contain pipe tables,
code spans, etc.) to HTML during Mako evaluation — before the outer
Markdown pass runs. The resulting HTML is then embedded inside the
<blockquote> as raw HTML and passes through unchanged, bypassing the
md_in_html nesting limitation that prevents Markdown processing inside
block-level HTML elements without explicit markdown="1" attributes.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Import from docassemble.base.filter and add to __all__ so the interview namespace can resolve it when rendering feedback body content. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Wrap each interview section in <div class="al_collapse_template"> so ALToolbox's collapse_template.css selectors (.al_collapse_template a span.pdcaretopen/pdcaretclosed) apply — this fixes both icons showing simultaneously and styles the toggle link as a dashed-underline control (not a plain blue hyperlink) - Replace <h3 class="h5 d-inline"> with <span class="subject h5"> so the title stays inline with the caret icon (h3 is block-level) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the feedback browsing admin page to make recent feedback easier to review and moves panelist information into the main tabbed UI.
Changes:
- Sorts saved feedback sessions by newest feedback timestamp first.
- Adds panelists as a third feedback tab instead of using help content.
- Converts open-answer feedback into collapsible per-interview sections with HTML rendering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
docassemble/GithubFeedbackForm/feedback_on_server.py |
Adds newest-first ordering for feedback session retrieval and exposes Markdown rendering to interviews. |
docassemble/GithubFeedbackForm/data/questions/browse_feedback_sessions.yml |
Updates the feedback summary UI with tabs, collapsible interview sections, and HTML table/link rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
uv run pytest fails because pytest is not declared in [dependency-groups] dev, so uv has no package to spawn. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
BryceStevenWilley
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #90
Some small changes:
In order for tables to render properly in the collapsible div, needed to import markdown_to_html and render some HTML manually instead of relying on e.g., markdown table formatting
Fixed separate issue with pytest not being a dev dependency so could run tests